Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing documentation for 2122 payload #3325

Merged
merged 1 commit into from
Sep 21, 2019
Merged

fixing documentation for 2122 payload #3325

merged 1 commit into from
Sep 21, 2019

Conversation

charleystran
Copy link
Contributor

Description of change

This fix is to update documentation that was referencing wring form

Acceptance Criteria (Definition of Done)

Applies to all PRs

  • Appropriate logging
  • Swagger docs have been updated, if applicable
  • Provide link to originating GitHub issue, or connected to it via ZenHub
  • Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)
  • Provide which alerts would indicate a problem with this functionality (if applicable)

@charleystran charleystran requested review from a team as code owners September 21, 2019 01:24
bastosmichael
bastosmichael approved these changes Sep 21, 2019
View reviewed changes
Copy link
Contributor

@bastosmichael bastosmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I missed this one, thanks for catching it.

@bastosmichael bastosmichael merged commit c189ad1 into master Sep 21, 2019
@johnpaulashenfelter johnpaulashenfelter deleted the documentation_update_for_2122 branch October 10, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastosmichael bastosmichael bastosmichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charleystran @bastosmichael @va-vfs-bot