Update drivetime_bands table fields #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpaulashenfelter
previously requested changes
Oct 4, 2019
There was a problem hiding this comment.
@nfasulo Changing an existing migration that is merged into production (even if the table is unused) is not going to lead to the change you want if migration has already been run.
This needs to be an additional migration to add these fields (and delete the other one, if that's what needs done and there's no data to lose)
edmkitty
reviewed
Oct 4, 2019
|
Thanks, @johnpaulashenfelter. Will correct. |
va-vfs-bot
temporarily deployed
to
nf/update-drivetime-bands-migration/master
annaswims
approved these changes
Oct 7, 2019
va-vfs-bot
temporarily deployed
to
nf/update-drivetime-bands-migration/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adding min and max values to the drive time bands instead of a single value. This will ensure that we are resilient to future changes to the size of the bands. This table is not yet in use.