Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add base64 support to multipart parser #3395

Merged
merged 9 commits into from
Oct 8, 2019

Conversation

charleystran
Copy link
Contributor

@charleystran charleystran commented Oct 7, 2019

Description of change

This change allows the benefits intake api to allow for the file contents to be base64 encoded on upload to S3

Testing done

rspec and local tests

Testing planned

testing on staging

Acceptance Criteria (Definition of Done)

  • a base64 encoded pdf can be uploaded and processed properly

Applies to all PRs

@charleystran charleystran requested review from a team as code owners October 7, 2019 15:13
@va-vfs-bot va-vfs-bot temporarily deployed to add_base64_support_to_multiparser/master October 7, 2019 15:55 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to add_base64_support_to_multiparser/master October 7, 2019 16:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to add_base64_support_to_multiparser/master October 7, 2019 18:31 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to add_base64_support_to_multiparser/master October 7, 2019 18:50 Inactive
Copy link
Contributor

@bastosmichael bastosmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to add_base64_support_to_multiparser/master October 7, 2019 23:55 Inactive
@charleystran charleystran merged commit 21138e2 into master Oct 8, 2019
@johnpaulashenfelter johnpaulashenfelter deleted the add_base64_support_to_multiparser branch October 10, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants