-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mobile & active status to nearby serializer #3397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked w/ @nfasulo and all the swagger docs and such were already updated and the serializer was what was missed.
This brings the actual behavior up to the specs.
Are there any tests for this that need to be updated? |
@edmkitty there are no tests that cover all the fields that the serializer returns, which is something that @johnpaulashenfelter brought up too. I'm not sure having another file to add the names of these two fields would have saved us in this case, but I'm open to adding specs for all of the facilities serializers. At this point facilities serializers are covered by the overall request specs (in this case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yet another approval
I have created a tech debt ticket for the writing tests for this and the rest of the facilities serializers: department-of-veterans-affairs/vets-contrib/issues/3331 |
Description of change
Adds
mobile
andactive_status
fields the the JSON response of/nearby
. The GeoJSON response for this endpoint and the documentation already include these two new fields.Reolves department-of-veterans-affairs/vets-contrib/issues/3323.
Testing done
Made request to
/nearby
on localhost to verify that the two new fields were included.Testing planned
Will make requests to
/nearby
in deployed environments to verify that the two new fields were included.Acceptance Criteria (Definition of Done)
Unique to this PR
/nearby
JSON response includesmobile
andactive_status
Applies to all PRs