Initialize facilities job error metric #3398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR helps address #3016
Facilities alerts currently fire indefinitely until vets-api-worker instance redeploy in Prometheus after a metric increments in StatsD. A PR exists to address this in the devops repo by only alerting when the failure counter for the most recent five minute window is greater than the failure counter for the most prior five minute window. However, that doesn't capture when the metric goes from not existing to existing the first time a failure occurs. To solve that case, we can either do some contortions in promQL to check for the absence of the metric, or we can initialize it to zero in vets-api. This PR does the latter.
Testing done
Acceptance Criteria (Definition of Done)
Unique to this PR
Applies to all PRs