create pssg download job #3438
Merged
create pssg download job #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
omgitsbillryan
approved these changes
Oct 17, 2019
Comment on lines
20
to
39
| vha_id = extract_vha_id(attributes) | ||
| facility = BaseFacility.find_facility_by_id(vha_id) | ||
| return if facility.nil? | ||
|
|
||
| drive_time_band = facility.drivetime_bands.find_or_initialize_by(vha_facility_id: extract_name(attributes)) | ||
| drive_time_band.min = attributes.dig('FromBreak') | ||
| drive_time_band.max = attributes.dig('ToBreak') | ||
| drive_time_band.name = attributes.dig('Name') | ||
| drive_time_band.polygon = extract_polygon(drive_time_data) | ||
| facility.save | ||
| end | ||
|
|
||
| def extract_name(attributes) | ||
| name = attributes.dig('Name') | ||
| name.partition(':').first.strip! | ||
| end | ||
|
|
||
| def extract_vha_id(attributes) | ||
| 'vha_' + extract_name(attributes) | ||
| end |
There was a problem hiding this comment.
You could get rid of def extract_vha_id and reduce the calls to extract_name from 2 down to 1 with something like this:
name = extract_name(attributes)
vha_id = 'vha_' + name
#...
drive_time_band = facility.drivetime_bands.find_or_initialize_by(vha_facility_id: name)There was a problem hiding this comment.
Thanks, I added some exception handling but not sure if it's pragmatically correct in ruby
edmkitty
reviewed
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Creates the PSSG download job
https://github.com/department-of-veterans-affairs/vets-contrib/issues/3103
Testing done
Created rspec for testing how it would interact with data coming from the drive time band client
Acceptance Criteria (Definition of Done)
Applies to all PRs