[10-10CG] - Change Facility VaSearchInput label (#33815)

* change facility search input label to a p since the component already has one

* move required label to content.json for caregivers

src/applications/caregivers/components/FormFields/FacilitySearch.jsx

@@ -305,16 +305,20 @@ const FacilitySearch = props => {
               searchInputError ? 'caregiver-facilities-search-input-error' : ''
             }`}
           >
-            <label
-              htmlFor="facility-search"
+            <p
               className="vads-u-margin-top--0 vads-u-margin-bottom--1"
+              aria-hidden="true"
             >
-              {content['form-facilities-search-label']}
-              <span className="vads-u-color--secondary-dark"> (*Required)</span>
-            </label>
+              {content['form-facilities-search-label']}{' '}
+              <span className="vads-u-color--secondary-dark">
+                {content['validation-required-label']}
+              </span>
+            </p>
             {searchInputError && searchError()}
             <VaSearchInput
-              label={content['form-facilities-search-label']}
+              label={`${content['form-facilities-search-label']} ${
+                content['validation-required-label']
+              }}`}
               value={query}
               onInput={handleChange}
               onSubmit={handleSearch}

src/applications/caregivers/locales/en/content.json

@@ -142,6 +142,7 @@
   "validation-facilities--search-required": "Enter a city, state or postal code",
   "validation-facilities--submit-search-required": "Select the search button",
   "validation-facilities--default-required": "Select a medical center or clinic",
+  "validation-required-label": "(*Required)",
   "validation-signature-required": "Must certify by checking box",
   "validation-sign-as-rep": "You must sign as representative.",
   "validation-sign-as-rep--vet-name": "Your signature must match previously entered name: %s",

src/applications/caregivers/tests/unit/components/FormFields/FacilitySearch.unit.spec.js

@@ -106,7 +106,7 @@ describe('CG <FacilitySearch>', () => {
       expect(selectors().moreFacilities).not.to.exist;
       expect(selectors().ariaLiveStatus).not.to.exist;
       expect(queryByText(content['form-facilities-search-label'])).to.exist;
-      expect(queryByText('(*Required)')).to.exist;
+      expect(queryByText(content['validation-required-label'])).to.exist;
     });
   });
 
@@ -699,7 +699,7 @@ describe('CG <FacilitySearch>', () => {
           expect(selectors().searchInputError.parentElement).to.have.class(
             'caregiver-facilities-search-input-error',
           );
-          expect(getByText('(*Required)')).to.exist;
+          expect(getByText(content['validation-required-label'])).to.exist;
         });
 
         it('renders error when trying to click goForward when no search value is present', () => {
@@ -713,7 +713,7 @@ describe('CG <FacilitySearch>', () => {
           expect(selectors().searchInputError.parentElement).to.have.class(
             'caregiver-facilities-search-input-error',
           );
-          expect(getByText('(*Required)')).to.exist;
+          expect(getByText(content['validation-required-label'])).to.exist;
         });
       });
     });