Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple forms add flipper for 21-4142 #24390

Merged
merged 4 commits into from
May 31, 2023
Merged

Simple forms add flipper for 21-4142 #24390

merged 4 commits into from
May 31, 2023

Conversation

gmrabian
Copy link
Contributor

Add flipper and static pages

Summary

  • Add feature flag (see backend PR)
  • Add widget build
  • Add static pages

Related issue(s)

Testing done

  • Static pages go to sitewide where they're implemented in Drupal, so we cannot test locally.
  • Followed setup based on previous form 26-4555

What areas of the site does it impact?

Form 21-4142 (not yet prod)

@va-vfs-bot va-vfs-bot temporarily deployed to master/simple-forms/flipper/21-4142/main May 31, 2023 14:15 Inactive
@gmrabian gmrabian mentioned this pull request May 31, 2023
Merged
jeana-adhoc
jeana-adhoc requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@jeana-adhoc jeana-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change commented above.

@gmrabian gmrabian requested a review from jeana-adhoc May 31, 2023 14:46
@va-vsp-bot va-vsp-bot requested a deployment to master/simple-forms/flipper/21-4142/main May 31, 2023 14:47 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/simple-forms/flipper/21-4142/main May 31, 2023 15:20 Inactive
@gmrabian gmrabian marked this pull request as ready for review May 31, 2023 15:22
@gmrabian gmrabian requested review from a team as code owners May 31, 2023 15:22
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request May 31, 2023
Closed
tlei123
tlei123 approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@tlei123 tlei123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmrabian gmrabian merged commit 23d76c5 into main May 31, 2023
@gmrabian gmrabian deleted the simple-forms/flipper/21-4142 branch May 31, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeana-adhoc jeana-adhoc jeana-adhoc approved these changes

@it-harrison it-harrison it-harrison approved these changes

@tlei123 tlei123 tlei123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gmrabian @tlei123 @it-harrison @jeana-adhoc @va-vfs-bot @va-vsp-bot