Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cypress real events #26342

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Update cypress real events #26342

merged 1 commit into from
Oct 24, 2023

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented Oct 24, 2023

Summary

  • (Summarize the changes that have been made to the platform)

    We're seeing Cypress test failures when using realType. These errors appear to resolve after updating the cypress-real-events library to the latest version (1.10.3)

  • (If bug, how to reproduce)

    Our Supplemental Claim e2e test (995-supplemental-claim.cypress.spec.js) appears to fail periodically while trying to realType into a va-text-input web component. After updating, this part of the test appears to be more stable. And has been disallowed for several weeks.

  • (What is the solution, why is this the solution)

    Update Cypress real-events library

  • (Which team do you work for, does your team own the maintenance of this component?)

    Benefits decision reviews

  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

#67960

Testing done

  • Describe what the old behavior was prior to the change

    Test would fail due to finding a "disabled" input (inside the va-text-input web component)

  • Describe the steps required to verify your changes are working as expected

    Running e2e tests multiple times

  • Describe the tests completed and the results

    Passing e2e tests

  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

N/A

What areas of the site does it impact?

All apps using real events (keyboard-only tests, etc)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@Mottie Mottie added dependencies Pull requests that update a dependency file bmt-team-1 Benefits Management Tools Team 1 Decision-Reviews-Team SC Supplemental Claim (Decision Reviews) labels Oct 24, 2023
@Mottie Mottie self-assigned this Oct 24, 2023
@Mottie Mottie requested a review from a team as a code owner October 24, 2023 16:05
@va-vfs-bot va-vfs-bot temporarily deployed to master/67960-update-real-events/main October 24, 2023 16:22 Inactive
Copy link
Contributor

@CBonade CBonade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mottie Mottie merged commit 9bf6784 into main Oct 24, 2023
@Mottie Mottie deleted the 67960-update-real-events branch October 24, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bmt-team-1 Benefits Management Tools Team 1 Decision-Reviews-Team dependencies Pull requests that update a dependency file SC Supplemental Claim (Decision Reviews)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants