Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appeals keyboard-only e2e tests #26357

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix appeals keyboard-only e2e tests #26357

merged 1 commit into from
Oct 25, 2023

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented Oct 24, 2023

Summary

  • (Summarize the changes that have been made to the platform)

    The keyboard-only end-to-end tests for our NOD (10182) and HLR (996) forms are on the disallowed list as being flaky. They are actually now failing due to changes within the form, changing paths and switching to use web components. This PR updates the tests to work.

  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)

    Update paths and selectors

  • (Which team do you work for, does your team own the maintenance of this component?)

    Benefits decision reviews

  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

#67960

Testing done

  • Describe what the old behavior was prior to the change

    Disallowed keyboard-only e2e tests were skipped

  • Describe the steps required to verify your changes are working as expected

    Check CI

  • Describe the tests completed and the results

    Updated HLR & NOD keyboard-only e2e tests

  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

N/A

What areas of the site does it impact?

Notice of Disagreement & Higher-Level Review forms

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@Mottie Mottie added front end testing HLR Higher-Level Review (Decision Reviews) NOD Notice of Disagreement (Decision Reviews) bmt-team-1 Benefits Management Tools Team 1 Decision-Reviews-Team labels Oct 24, 2023
@Mottie Mottie self-assigned this Oct 24, 2023
@Mottie Mottie requested review from a team as code owners October 24, 2023 20:48
@va-vfs-bot va-vfs-bot temporarily deployed to master/67960-keyboard-e2e/main October 24, 2023 21:12 Inactive
@Mottie Mottie merged commit 7719c28 into main Oct 25, 2023
@Mottie Mottie deleted the 67960-keyboard-e2e branch October 25, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bmt-team-1 Benefits Management Tools Team 1 Decision-Reviews-Team front end HLR Higher-Level Review (Decision Reviews) NOD Notice of Disagreement (Decision Reviews) testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants