Make call to next_steps_email on downloads button click #32029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
va-vfs-bot
temporarily deployed
to
master/hh-92783-make-call-to-next_steps_email-endpoint/main
va-vfs-bot
temporarily deployed
to
master/hh-92783-make-call-to-next_steps_email-endpoint/main
va-vfs-bot
temporarily deployed
to
master/hh-92783-make-call-to-next_steps_email-endpoint/main
va-vfs-bot
temporarily deployed
to
master/hh-92783-make-call-to-next_steps_email-endpoint/main
va-vfs-bot
temporarily deployed
to
master/hh-92783-make-call-to-next_steps_email-endpoint/main
holdenhinkle
commented
Sep 25, 2024
| formName: getFormName(), | ||
| }); | ||
| } catch (error) { | ||
| // Should we set an error state to display a message in the UI? |
There was a problem hiding this comment.
We need to tell the user on the /next-steps page that the call to send the email failed.
va-vfs-bot
temporarily deployed
to
master/hh-92783-make-call-to-next_steps_email-endpoint/main
va-vfs-bot
temporarily deployed
to
master/hh-92783-make-call-to-next_steps_email-endpoint/main
va-vfs-bot
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Sentry call found
Sentry captures a lot of data, and we want to make sure that we only keep information that will be useful for troubleshooting issues. This means that PII should not be recorded.
What you can do
Review your call to Sentry and see if you can reasonably reduce any information that is included, or wait for a VSP review.
|
|
||
| return await response.json(); | ||
| } catch (error) { | ||
| Sentry.captureException(new Error(`API request failed: ${error.message}`)); |
cosu419
previously approved these changes
Sep 26, 2024
va-vfs-bot
temporarily deployed
to
master/hh-92783-make-call-to-next_steps_email-endpoint/main
va-vfs-bot
temporarily deployed
to
master/hh-92783-make-call-to-next_steps_email-endpoint/main
va-vfs-bot
temporarily deployed
to
master/hh-92783-make-call-to-next_steps_email-endpoint/main
cosu419
approved these changes
Sep 27, 2024
pjhill
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves department-of-veterans-affairs/va.gov-team#92783
When a user clicks "Continue" on the download page, we make a request to VA Notify to send a confirmation email.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
When a user clicks "Continue" on the download page, we make a request to VA Notify to send a confirmation email.
Related issue(s)
Testing done
Screenshots
NA
What areas of the site does it impact?
Just the Appoint a Rep app which is still behind a feature flag.
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
NA