Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature toggle for Vet Status card LH API usage #33038

Merged
merged 9 commits into from
Nov 20, 2024

Conversation

khenson-oddball
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • This PR adds a feature toggle for the Veteran Status card feature to use the Lighthouse API instead of the Profile API. This will help our team test out this new API integration.
  • I work on the IIR Product team and we currently own this feature.
  • The success criteria targeted is to make sure that we receive the same access rate or better for known test users when trying to view their Vet Status card.
  • The companion vets-api PR is here.

Related issue(s)

Testing done

  • This change only includes adding a new feature toggle.

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

This change only includes adding a new feature toggle.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/iir-1144-add-vet-status-lh-feature-toggle/main November 15, 2024 00:36 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/iir-1144-add-vet-status-lh-feature-toggle/main November 15, 2024 17:08 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/iir-1144-add-vet-status-lh-feature-toggle/main November 15, 2024 18:42 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/iir-1144-add-vet-status-lh-feature-toggle/main November 15, 2024 20:04 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/iir-1144-add-vet-status-lh-feature-toggle/main November 19, 2024 18:49 Inactive
@khenson-oddball khenson-oddball marked this pull request as ready for review November 19, 2024 19:02
@khenson-oddball khenson-oddball requested a review from a team as a code owner November 19, 2024 19:02
Copy link
Contributor

@harshil1793 harshil1793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating your branch with latest main will fix the failing CI tests. Once its all passing I can go ahead and approve the PR.

@khenson-oddball khenson-oddball merged commit 21605d1 into main Nov 20, 2024
62 checks passed
@khenson-oddball khenson-oddball deleted the iir-1144-add-vet-status-lh-feature-toggle branch November 20, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants