-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature toggle for Vet Status card LH API usage #33038
Merged
khenson-oddball
merged 9 commits into
main
from
iir-1144-add-vet-status-lh-feature-toggle
Nov 20, 2024
Merged
Add feature toggle for Vet Status card LH API usage #33038
khenson-oddball
merged 9 commits into
main
from
iir-1144-add-vet-status-lh-feature-toggle
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
8 tasks
va-vfs-bot
temporarily deployed
to
master/iir-1144-add-vet-status-lh-feature-toggle/main
November 15, 2024 00:18
Inactive
va-vfs-bot
temporarily deployed
to
master/iir-1144-add-vet-status-lh-feature-toggle/main
November 15, 2024 00:36
Inactive
va-vfs-bot
temporarily deployed
to
master/iir-1144-add-vet-status-lh-feature-toggle/main
November 15, 2024 17:08
Inactive
va-vfs-bot
temporarily deployed
to
master/iir-1144-add-vet-status-lh-feature-toggle/main
November 15, 2024 18:42
Inactive
va-vfs-bot
temporarily deployed
to
master/iir-1144-add-vet-status-lh-feature-toggle/main
November 15, 2024 20:04
Inactive
va-vfs-bot
temporarily deployed
to
master/iir-1144-add-vet-status-lh-feature-toggle/main
November 19, 2024 18:49
Inactive
kpethtel
approved these changes
Nov 19, 2024
harshil1793
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating your branch with latest main will fix the failing CI tests. Once its all passing I can go ahead and approve the PR.
harshil1793
approved these changes
Nov 20, 2024
khenson-oddball
deleted the
iir-1144-add-vet-status-lh-feature-toggle
branch
November 20, 2024 19:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Related issue(s)
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
This change only includes adding a new feature toggle.
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?