Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open directions and need help links in the same tab #33766

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Dec 26, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • This updates directions and need help links to open in the same tab
  • Appointments (VAOS) Team
  • This is not behind a Flipper

Related issue(s)

Testing done

  • Tested locally, see screenshots

Screenshots

Link(s) Screenshot and HTML
Directions - Before image
Directions - After image
Need help - Before image
Need help - After image

What areas of the site does it impact?

Appointments (VAOS)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@JunTaoLuo
Copy link
Contributor Author

FYI @outerpress the NewTabAnchor used to add aria labels to the links that open in a new tab but I didn't include the label in the new links. The reason is that the aria label used to appends the suffix "Link opens in a new tab." to whatever the text of the link was. Given that we are no longer opening these in a new tab, without that suffix, the label will just be the same as the visible text. In that case I think it would be redundant even for screen readers, but let me know if that's not true and I can add the aria labels back.

@outerpress
Copy link

FYI @outerpress the NewTabAnchor used to add aria labels to the links that open in a new tab but I didn't include the label in the new links.

That makes sense to me @JunTaoLuo - I'll test these with a screenreader when I validate

Copy link
Contributor

@simiadebowale simiadebowale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunTaoLuo JunTaoLuo merged commit a950771 into main Dec 30, 2024
79 checks passed
@JunTaoLuo JunTaoLuo deleted the jtluo/help-directions-tabs branch December 30, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants