98828 Add initial RUM implementation - form 10-10d #33772
+98
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/98828-monitoring-rum-dashboard-setup/main
michaelclement
commented
Dec 26, 2024
There was a problem hiding this comment.
Adds RUM initialization function (modified from EZR form example).
michaelclement
commented
Dec 26, 2024
Comment on lines
+20
to
+21
| sessionSampleRate: 100, | ||
| sessionReplaySampleRate: 100, |
There was a problem hiding this comment.
Defaulting to 100% because we need to test in staging. Once we decide to start using in prod, this will have to change to a significantly reduced percentage.
michaelclement
commented
Dec 26, 2024
There was a problem hiding this comment.
Helper used later with useMemo to get relevant feature toggle state
9 tasks
va-vfs-bot
temporarily deployed
to
master/98828-monitoring-rum-dashboard-setup/main
cloudmagic80
previously approved these changes
Dec 27, 2024
michaelclement
commented
Dec 30, 2024
Comment on lines
+6
to
+12
| import { VaBreadcrumbs } from '@department-of-veterans-affairs/component-library/dist/react-bindings'; | ||
| import PropTypes from 'prop-types'; | ||
| import RoutedSavableApp from 'platform/forms/save-in-progress/RoutedSavableApp'; | ||
| import { VaBreadcrumbs } from '@department-of-veterans-affairs/component-library/dist/react-bindings'; | ||
| import { Toggler } from 'platform/utilities/feature-toggles'; | ||
| import formConfig from '../config/form'; | ||
| import WIP from '../../shared/components/WIP'; | ||
| import { useBrowserMonitoring } from '../helpers/useBrowserMonitoring'; |
There was a problem hiding this comment.
reordered, nothing important here.
…artment-of-veterans-affairs/vets-website into 98828-monitoring-rum-dashboard-setup
michaelclement
commented
Dec 30, 2024
Comment on lines
+34
to
+53
| const useBrowserMonitoring = () => { | ||
| // Retrieve feature flag values to control behavior | ||
| const selectFeatureToggles = useMemo(makeSelectFeatureToggles, []); | ||
| const featureToggles = useSelector(selectFeatureToggles); | ||
| const { isBrowserMonitoringEnabled, isLoadingFeatureFlags } = featureToggles; | ||
|
|
||
| useEffect( | ||
| () => { | ||
| if (isLoadingFeatureFlags) return; | ||
| if (isBrowserMonitoringEnabled) { | ||
| initializeRealUserMonitoring(); | ||
| } else { | ||
| delete window.DD_RUM; | ||
| } | ||
| }, | ||
| [isBrowserMonitoringEnabled, isLoadingFeatureFlags], | ||
| ); | ||
| }; | ||
|
|
||
| export { useBrowserMonitoring }; |
There was a problem hiding this comment.
Based on existing RUM config examples in vets-website. Uses memoized feature toggle info when initializing RUM.
michaelclement
commented
Dec 30, 2024
Comment on lines
+1
to
+17
| import { createSelector } from 'reselect'; | ||
| import { toggleValues } from '@department-of-veterans-affairs/platform-site-wide/selectors'; | ||
| import FEATURE_FLAG_NAMES from '@department-of-veterans-affairs/platform-utilities/featureFlagNames'; | ||
|
|
||
| const selectFeatureToggles = createSelector( | ||
| state => ({ | ||
| isLoadingFeatureFlags: state?.featureToggles?.loading, | ||
| isBrowserMonitoringEnabled: toggleValues(state)[ | ||
| FEATURE_FLAG_NAMES.form1010dBrowserMonitoringEnabled | ||
| ], | ||
| }), | ||
| toggles => toggles, | ||
| ); | ||
|
|
||
| const makeSelectFeatureToggles = () => selectFeatureToggles; | ||
|
|
||
| export { makeSelectFeatureToggles }; |
There was a problem hiding this comment.
Based on existing RUM config examples in vets-website. Creates a redux selector so these extra bits of state can be derived rather than directly stored.
cloudmagic80
approved these changes
Dec 30, 2024
va-vfs-bot
reviewed
Dec 30, 2024
src/applications/ivc-champva/10-10D/tests/unit/selectors/feature-toggles.unit.spec.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
This PR adds the RUM initialization to form 10-10d so it can be monitored in this dashboard. Feature is behind a flipper (matching BE PR) so it can be first tested in staging.
Related issue(s)
Testing done
Screenshots
NA
What areas of the site does it impact?
This form only.
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
NA