Restructure date calculations to avoid manual modular logic #33788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you removing, renaming or moving a folder in this PR?
TeamSites
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
2024-12-27
became2025-00-27
, which was incorrectly considered above2024-12-31
. This PR replaces the manual date + year manipulation and modular math with JS'sDate.setMonth()
logic. As a pleasant surprise,date.setMonth(date.getMonth()+2)
even correctly shifts across year boundaries.Related issue(s)
#octo-ves-healthcare-enrollment
at https://dsva.slack.com/archives/C06FDF2EN0H/p1735333763795659Testing done
What areas of the site does it impact?
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?