Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sciunit will fail when an argument contains an apostrophe.
For example:
The query that sciunit generates looks like this;
Since the third line is delimited by apostrophes, and third argument,
echo 'hello'
, contains an apostrophe, it breaks the query.Instead of this Python sqlite supports using
?
as a place-holder for that argument. If we use placeholder, then the statement will be parsed correctly, even if the value of the placeholder has an apostrophe or any other special character.While this is only strictly necessary for
commit
, I decided to change the other two (integer valued) queries as well because its better practice to use place-holders.