fix python-index not added to credentials-metadata #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
changed the title
landongrindheim
approved these changes
Jan 2, 2024
mctofu
reviewed
Jan 2, 2024
| entry := make(map[string]any) | ||
| for k, v := range credential { | ||
| // Updater does not get credentials. | ||
| if k != "token" && k != "password" { |
There was a problem hiding this comment.
Hex org & repos have some additional keys: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#hex-organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #196
When using a job definition containing credentials for a python index, the Dependabot CLI was not correctly updating the credentials metadata which is passed to the Updater.
To fix this I flipped the logic to exclude
tokenandpasswordduring the metadata population routine, which should also fix any others that we might have missed or any that are added in the future.