Skip to content

Commit

Permalink
pipenv renamed internal patch.notpip -> patch.pip
Browse files Browse the repository at this point in the history
Upstream `pipenv` renamed their internal patched version of `pip` folder
to be called `patch.pip`:
* pypa/pipenv#5199

So this updates our code as well.
  • Loading branch information
jeffwidman committed Aug 10, 2023
1 parent f890fc9 commit 7267496
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,9 @@ class UpdateChecker
# just raise if the latest version can't be resolved. Knowing that is
# still better than nothing, though.
class PipenvVersionResolver
# rubocop:disable Layout/LineLength
GIT_DEPENDENCY_UNREACHABLE_REGEX = /git clone --filter=blob:none (?<url>[^\s]+).*/
GIT_REFERENCE_NOT_FOUND_REGEX = /git checkout -q (?<tag>[^\s]+).*/
PIPENV_INSTALLATION_ERROR = "pipenv.patched.notpip._internal.exceptions.InstallationError: Command errored out" \
PIPENV_INSTALLATION_ERROR = "pipenv.patched.pip._internal.exceptions.InstallationError: Command errored out" \
" with exit status 1: python setup.py egg_info"
TRACEBACK = "Traceback (most recent call last):"
PIPENV_INSTALLATION_ERROR_REGEX =
Expand All @@ -41,7 +40,6 @@ class PipenvVersionResolver
UNSUPPORTED_DEP_REGEX =
/Could not find a version that satisfies the requirement.*(?:#{UNSUPPORTED_DEPS.join("|")})/
PIPENV_RANGE_WARNING = /Warning:\sPython\s[<>].* was not found/
# rubocop:enable Layout/LineLength

DEPENDENCY_TYPES = %w(packages dev-packages).freeze

Expand Down Expand Up @@ -260,7 +258,7 @@ def clean_error_message(message)
next false if l.start_with?("CRITICAL:")
next false if l.start_with?("ERROR:")
next false if l.start_with?("packaging.specifiers")
next false if l.start_with?("pipenv.patched.notpip._internal")
next false if l.start_with?("pipenv.patched.pip._internal")
next false if l.include?("Max retries exceeded")

true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
expect { subject }.
to raise_error(Dependabot::DependencyFileNotResolvable) do |error|
expect(error.message).to start_with(
"CRITICAL:pipenv.patched.notpip._internal.resolution.resolvelib.factory:" \
"CRITICAL:pipenv.patched.pip._internal.resolution.resolvelib.factory:" \
"Could not find a version that satisfies the requirement " \
"pytest==10.4.0"
)
Expand Down

0 comments on commit 7267496

Please sign in to comment.