Skip to content

Commit

Permalink
Fix flaky npm 6 peer dependency test
Browse files Browse the repository at this point in the history
It looks like this spec has become flaky recently, not clear why but
seems to have fixed it by making the expectation compare the dependency
hash instead of the instance.

Also removed the alias on `npm6` as we no longer install npm7 as a npm package.
  • Loading branch information
feelepxyz committed Mar 4, 2021
1 parent 14a6190 commit e695105
Show file tree
Hide file tree
Showing 6 changed files with 10,239 additions and 5,979 deletions.
4 changes: 2 additions & 2 deletions npm_and_yarn/helpers/lib/npm6/peer-dependency-checker.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
* - successful completion, or an error if there are peer dependency warnings
*/

const npm = require("npm6");
const installer = require("npm6/lib/install");
const npm = require("npm");
const installer = require("npm/lib/install");
const { muteStderr, runAsync } = require("./helpers.js");

function installArgsWithVersion(depName, desiredVersion, reqs) {
Expand Down
4 changes: 2 additions & 2 deletions npm_and_yarn/helpers/lib/npm6/subdependency-updater.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const fs = require("fs");
const path = require("path");
const npm = require("npm6");
const installer = require("npm6/lib/install");
const npm = require("npm");
const installer = require("npm/lib/install");
const detectIndent = require("detect-indent");
const removeDependenciesFromLockfile = require("./remove-dependencies-from-lockfile");

Expand Down
4 changes: 2 additions & 2 deletions npm_and_yarn/helpers/lib/npm6/updater.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
*/
const fs = require("fs");
const path = require("path");
const npm = require("npm6");
const installer = require("npm6/lib/install");
const npm = require("npm");
const installer = require("npm/lib/install");
const detectIndent = require("detect-indent");
const { muteStderr, runAsync } = require("./helpers.js");

Expand Down
Loading

0 comments on commit e695105

Please sign in to comment.