Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to disable for a fork? #2804

Closed
hugovk opened this issue Nov 30, 2020 · 49 comments
Closed

How to disable for a fork? #2804

hugovk opened this issue Nov 30, 2020 · 49 comments
Labels
F: noise related to Dependabot being noisy, or initiatives to make Dependabot quieter L: docker Docker containers L: git:submodules Git submodules L: go:modules Golang modules L: javascript L: python L: ruby:bundler RubyGems via bundler T: bug 🐞 Something isn't working

Comments

@hugovk
Copy link

hugovk commented Nov 30, 2020

I enabled Dependabot for a fork (https://github.com/hugovk/pytest), to make sure it was working smoothly before creating a PR to add it upstream (https://github.com/pytest-dev/pytest). Upstream is now using it, it's working well, thanks!

However, I now want to disable Dependabot for my fork but cannot find a way.

https://app.dependabot.com/accounts/hugovk says:

You've successfully migrated pytest to GitHub 🎉

image

At https://github.com/settings/installations/8631454, Dependabot Preview only has access to other repos:

image

At https://github.com/hugovk/pytest/settings/security_analysis I have everything disabled:

image

Deleting https://github.com/hugovk/pytest/blob/master/.github/dependabot.yml is not an option, because this is a fork, and it needs to be kept in sync with upstream.

How can I disable Dependabot for my fork?

Package manager/ecosystem

Python

Manifest contents prior to update

version: 2
updates:
- package-ecosystem: pip
  directory: "/testing/plugins_integration"
  schedule:
    interval: weekly
    time: "03:00"
  open-pull-requests-limit: 10
  allow:
  - dependency-type: direct
  - dependency-type: indirect

https://github.com/hugovk/pytest/blob/master/.github/dependabot.yml
https://github.com/hugovk/pytest/blob/master/testing/plugins_integration/requirements.txt


Edit: as the 2022-11-24 solution is obscured by the thousands of hidden items below, here it is for clarity:

Hmm... from when we shipped this on November 7th going forward, no repos should be default opted-in.

One exception is any repo, fork-or-no-fork will be automatically opted in if you've selected the Automatically enable for new repositories option in your user or org settings. But that's essentially inheriting a manual opt-in.

Forks that were created before November 7th will require manual disabling... we considered disabling them, but couldn't easily distinguish between those who did/didn't manually enable it from the beginning, so it was safer/more predictable for users if we left them untouched.

To disable, as @hugovk mentions above you need to either delete/re-create the fork, or click Disable on the forked repo's /settings/security_analysis page:

image

For PR's that were already sitting open when you disable Dependabot, I think nothing further happens to them unless you do it. They won't get auto-rebased or auto-closed.

@hugovk hugovk added the T: bug 🐞 Something isn't working label Nov 30, 2020
@Mariatta
Copy link

Mariatta commented Dec 1, 2020

This is happening in CPython repo as well which has 17K forks. It would help us greatly if dependabot can be disabled in forks. Thanks.

@feelepxyz
Copy link
Contributor

We're aware of this issue and planning a fix. The workaround for now is to delete the fork and re-create it without enabling Dependabot security updates. Dependabot version updates (setup from config file) isn't enabled by default on new forks but will be if security updates has ever been turned on and since disabled.

@patcon
Copy link

patcon commented Jan 26, 2021

Thanks for clearly communicating! Any "ish" timeline on this?

(I have unrelated issues in the forks, so deleting and recreating isn't quite as easy as it could be.)

@feelepxyz
Copy link
Contributor

@patcon we'll get to it in the next couple of months :/ going to bump it up again with the team and see if we can get to it sooner.

@wesinator
Copy link

Getting this issue on a fork of https://github.com/EFForg/https-everywhere

Disabling actions did not prevent new PRs being generated

@ldez
Copy link

ldez commented Feb 26, 2021

Seems to be a duplicate of #2198

@trivikr
Copy link

trivikr commented May 4, 2021

@feelepxyz bumping it again, as it has been three months since this comment in #2804 (comment)

Screen Shot 2021-05-04 at 7 53 25 AM

@featheredtoast
Copy link

The workaround also doesn't work for forks I want private because I cannot change visibility of a (Github) fork, so I'm mirroring instead. Would the solution here also allow us to disable dependabot in mirrored repositories?

@return42
Copy link

return42 commented Jun 18, 2021

I think there is a need to act here because each fork has a master branch that cannot be changed from upstream after the fork is created. Those dependabots from forks will run infinite! At least as long as the owner of the fork does not fix his master branch what is expectable for 99% of the forks. Thinking global, this is a totally unneeded wast of resources and energy ...

glensc added a commit to glensc/PlexTraktSync that referenced this issue Feb 13, 2023
gyohuangxin pushed a commit to intel/envoy that referenced this issue Feb 16, 2023
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
soulxu pushed a commit to intel/envoy that referenced this issue Mar 8, 2023
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
basil added a commit to basil/repository-permissions-updater that referenced this issue Apr 17, 2023
basil added a commit to basil/pipeline-library that referenced this issue Apr 17, 2023
gyohuangxin pushed a commit to intel/envoy that referenced this issue May 22, 2023
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
gyohuangxin pushed a commit to intel/envoy that referenced this issue May 22, 2023
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
gyohuangxin pushed a commit to intel/envoy that referenced this issue Jun 8, 2023
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
gyohuangxin pushed a commit to intel/envoy that referenced this issue Jun 12, 2023
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
gyohuangxin pushed a commit to intel/envoy that referenced this issue Aug 22, 2023
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
gyohuangxin pushed a commit to intel/envoy that referenced this issue Sep 6, 2023
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
gyohuangxin pushed a commit to intel/envoy that referenced this issue Oct 17, 2023
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
gyohuangxin pushed a commit to intel/envoy that referenced this issue Dec 20, 2023
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
gyohuangxin pushed a commit to intel/envoy that referenced this issue Feb 24, 2024
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
gyohuangxin pushed a commit to intel/envoy that referenced this issue Feb 24, 2024
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
basil added a commit to basil/neanes that referenced this issue Mar 11, 2024
gyohuangxin pushed a commit to intel/envoy that referenced this issue Mar 15, 2024
Since currently dependabot cannot be disabled on forks, remove
dependabot.yml

For more info:
dependabot/dependabot-core#2804

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
@github-actions github-actions bot added L: docker Docker containers L: git:submodules Git submodules L: go:modules Golang modules L: javascript L: python L: ruby:bundler RubyGems via bundler labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: noise related to Dependabot being noisy, or initiatives to make Dependabot quieter L: docker Docker containers L: git:submodules Git submodules L: go:modules Golang modules L: javascript L: python L: ruby:bundler RubyGems via bundler T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests