Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo: fix git credential helper issue #1000

Merged
merged 3 commits into from
Feb 20, 2019

Conversation

hmarr
Copy link
Contributor

@hmarr hmarr commented Feb 15, 2019

Cargo (well, git2-rs) doesn't accept the 'command with args' form of specifying a git credential helper. It does, however, accept the shell snippet form, which is prefixed with a !.

I still need to confirm that this doesn't break regular git (all other languages).

Cargo (well, git2-rs) doesn't accept the 'command with args' form of
specifying a git credential helper. It does, however, accept the shell
snippet form, which is prefixed with a !.
@hmarr hmarr force-pushed the fix-cargo-git-credential-helper-issue branch from e6bc0d0 to bc1304d Compare February 19, 2019 17:45
@hmarr hmarr merged commit 5686fb6 into master Feb 20, 2019
@hmarr hmarr deleted the fix-cargo-git-credential-helper-issue branch February 20, 2019 01:47
@hmarr
Copy link
Contributor Author

hmarr commented Feb 20, 2019

For future reference:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant