allow empty version after comma in a requirement #10713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbayes-msft
approved these changes
Oct 2, 2024
brettfo
force-pushed
the
dev/brettfo/nuget-illformed-requirement
branch
from
87412e7
to
109d186
Compare
sebasgomez238
approved these changes
Oct 2, 2024
brettfo
force-pushed
the
dev/brettfo/nuget-illformed-requirement
branch
2 times, most recently
from
44a6f38
to
5d4f6cd
Compare
JamieMagee
approved these changes
Oct 2, 2024
brettfo
force-pushed
the
dev/brettfo/nuget-illformed-requirement
branch
from
5d4f6cd
to
8c1fcc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement strings were found in the wild with a trailing comma, e.g.,
>= 1.40.0,A quick check of two other requirement handlers, NPM and Python, both allow for an empty value so the NuGet version is being updated as well.