do case-insensitive comparison for lead_security_dependency experiment
#10861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
approved these changes
Oct 28, 2024
jeffwidman
reviewed
Oct 29, 2024
|
@jeffwidman I've pushed a commit with a unit test. I first verified that the test failed without the |
jeffwidman
approved these changes
Oct 30, 2024
sachin-sandhu
force-pushed
the
dev/brettfo/downcase-dep-name
branch
from
4c48c42
to
a9ca304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lead_security_dependencyexperiment is downcasing only one half of the dependency name comparison resulting in closed PRs in an ecosystem where the current packages are reported with some upper case characters, e.g., NuGet reportingSystem.Text.Jsonand that string not matchingsystem.text.json. The result is that the comparison on line 155 is returningfalse:dep.name.downcase == lead_dep_namewherelead_dep_namecomes fromsecurity_advisory_dependency. The NuGet example then expands to"system.text.json" == "System.Text.Json" # => false.The fix is to restore the call to
.downcasethat is present when the experiment isn't enabled.