Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for build-system.requires in pyproject.toml #10899

Merged

Conversation

gopidesupavan
Copy link
Contributor

What are you trying to accomplish?

This adds support for build-system requires in pyproject.toml files.

related: #8465

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Executed dry run scipt that produces this output. have used my git repo with sample pyproject.toml

bin/dry-run.rb pip gopidesupavan/workspace-poc

https://github.com/gopidesupavan/workspace-poc/blob/main/pyproject.toml

bin/dry-run.rb:728:in `block in <main>'
bin/dry-run.rb:620:in `each'
bin/dry-run.rb:620:in `<main>'
 => build-system: bump: bump flit-core from 1 to 3.10.1

    ± pyproject.toml
    ~~~
    --- /tmp/original20241106-114043-w2gv8e     2024-11-06 17:52:24.124167518 +0000
    +++ /tmp/updated20241106-114043-q7mclq      2024-11-06 17:52:24.124167518 +0000
    @@ -1,5 +1,5 @@
     [build-system]
    -requires = ["flit_core==1"]
    +requires = ["flit_core==3.10.1"]
     build-backend = "flit_core.buildapi"
     
     [project]
    ~~~
    2 insertions (+), 2 deletions (-)
🌍 Total requests made: '26'

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
    Not able to run complete tests on my machine
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@gopidesupavan gopidesupavan requested a review from a team as a code owner November 6, 2024 18:19
@gopidesupavan
Copy link
Contributor Author

cc: @potiuk

@gopidesupavan
Copy link
Contributor Author

I also built the updater-pip image locally and ran the CLI command, which produced this output. This confirms that the flit-core dependency is updating and is listed under build-system.requires in the https://github.com/gopidesupavan/workspace-poc/blob/main/pyproject.toml#L2

updater | 2024/11/06 19:18:30 INFO Finished job processing
updater | 2024/11/06 19:18:30 INFO Results:
updater | +---------------------------------------------------+
updater | |        Changes to Dependabot Pull Requests        |
updater | +---------+-----------------------------------------+
updater | | created | ansys-templates ( from 0.3.0 to 4.0.0 ) |
updater | | created | flit-core ( from 1 to 3.10.1 )          |
updater | +---------+-----------------------------------------+
  proxy | 2024/11/06 19:18:31 Skipping sending metrics because api endpoint is empty
  proxy | 2024/11/06 19:18:31 30/57 calls cached (52%)

@potiuk
Copy link

potiuk commented Nov 7, 2024

NICE!

@sachin-sandhu
Copy link
Contributor

@gopidesupavan , thank you for the hard work!, we are reviewing the PR right now , will come back in case of any queries.

@gopidesupavan
Copy link
Contributor Author

@gopidesupavan , thank you for the hard work!, we are reviewing the PR right now , will come back in case of any queries.

@sachin-sandhu thank you :)

@sachin-sandhu sachin-sandhu force-pushed the project-toml-dependency-requires branch from 2c7d9ae to 3c4fc11 Compare November 8, 2024 13:53
Copy link
Contributor

@sachin-sandhu sachin-sandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me.

@sachin-sandhu
Copy link
Contributor

Update:

We monitored the deploy for some time and don't see any new issues coming up, we are merging the code now

@sachin-sandhu sachin-sandhu merged commit b5d0600 into dependabot:main Nov 8, 2024
44 checks passed
@gopidesupavan gopidesupavan deleted the project-toml-dependency-requires branch November 9, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants