-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for build-system.requires in pyproject.toml #10899
Adding support for build-system.requires in pyproject.toml #10899
Conversation
cc: @potiuk |
I also built the updater-pip image locally and ran the CLI command, which produced this output. This confirms that the flit-core dependency is updating and is listed under build-system.requires in the https://github.com/gopidesupavan/workspace-poc/blob/main/pyproject.toml#L2
|
NICE! |
@gopidesupavan , thank you for the hard work!, we are reviewing the PR right now , will come back in case of any queries. |
@sachin-sandhu thank you :) |
2c7d9ae
to
3c4fc11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good to me.
Update: We monitored the deploy for some time and don't see any new issues coming up, we are merging the code now |
What are you trying to accomplish?
This adds support for build-system requires in pyproject.toml files.
related: #8465
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Executed dry run scipt that produces this output. have used my git repo with sample pyproject.toml
bin/dry-run.rb pip gopidesupavan/workspace-poc
https://github.com/gopidesupavan/workspace-poc/blob/main/pyproject.toml
Checklist
Not able to run complete tests on my machine