Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for centralized package manager & language abstraction fo… #10929

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Nov 13, 2024

…r maven

What are you trying to accomplish?

Update the maven ecosystem to add support for gathering ecosystem metrics that need to be persisted in datadog via POST /update_jobs/:id/record_ecosystem_meta

Anything you want to highlight for special attention from reviewers?

This is one in a series of PRs to gather ecosystem meta data and persist it in datadog. See earlier PRs for Bundler and NPM

In this PR, I'm returning NOT-AVAILABLE for the maven version and java version. From my investigations thus far, there is no consistent way to gather this data as we don't actually run maven when generating dependabot updates. All the processing seems to be done in Ruby. As discussed with @kbukum1 and @abdulapopoola I've created Issue-7534 to track this issue.

How will you know you've accomplished your goal?

  • I'll be able to see maven ecosystem metrics in datadog

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added the L: java:maven Maven packages via Maven label Nov 13, 2024
@amazimbe amazimbe force-pushed the amazimbe/maven-ecosystem-meta branch from e71e671 to 8da8e38 Compare November 14, 2024 16:06
@amazimbe amazimbe self-assigned this Nov 14, 2024
@amazimbe amazimbe force-pushed the amazimbe/maven-ecosystem-meta branch from 35036cd to 89fee53 Compare November 15, 2024 14:19
@amazimbe amazimbe marked this pull request as ready for review November 15, 2024 14:42
@amazimbe amazimbe requested a review from a team as a code owner November 15, 2024 14:42
@amazimbe amazimbe merged commit 938cbb9 into main Nov 15, 2024
83 checks passed
@amazimbe amazimbe deleted the amazimbe/maven-ecosystem-meta branch November 15, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: java:maven Maven packages via Maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants