Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some recent stability issues with the NuGet tests, specifically the test hanging for several hours. Being perfectly honest, I have no idea what's happening, but I've made the following changes that should make the issues easier to find:
ci-test
. This makes the test output easier to read.--blame-hang-timeout 5m
which means any individual test that is still running after 5 minutes will be killed. I think the longest running C# test is currently ~10 seconds, so the 5 minute limit should be plenty. If this timeout is hit, we'll know exactly what test caused it.turbo_tests
was removed). I suspect this was the real culprit, because in some of the hang cases the C# tests never even got a chance to start.Downsides to this change. The Ruby unit tests are no longer run in parallel across 4 cores; they're run serially, however this only results in a CI increase of a few seconds; all pure Ruby tests usually run in under 30 seconds anyway.
While repeatedly running the CI, I found some flaky Ruby unit tests in
file_updater_spec.rb
. I've moved the handling of the temp job file closer to where it's used and I haven't seen the flakiness return.So far I've run the CI 20 times with the current changes (modulo some minor tweaks) and haven't seen the timeout/hang, where before I would see it ~1/10 times. I will run this several more times to be sure. Apologies to whoever pays the CI bill.