-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Composer v1 Code and Related Feature Flags #10934
Remove Composer v1 Code and Related Feature Flags #10934
Conversation
This PR doesn't include the removal of the v1 folder, will that be in a separate PR? |
@abdulapopoola , Had some issues pushing v1 delete changes , pushed them now. |
In a separate PR to avoid bloating up this PR, we should look at renaming the v2 folder too since that is the only version left. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. Other then that looks good to me.
9600e75
to
bb4b5c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What are you trying to accomplish?
Preface: Copy => As Dependabot no longer supports Composer v1, this issue tracks the removal of all Composer v1-specific code, including feature flags associated with its deprecation and unsupported status (composer_v1_deprecation_warning and composer_v1_unsupported_error). This cleanup will ensure that only Composer v2 and higher versions are supported moving forward.
Removal process: Following steps were performed to remove the support for v1
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist