Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Composer v1 Code and Related Feature Flags #10934

Merged

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Nov 14, 2024

What are you trying to accomplish?

Preface: Copy => As Dependabot no longer supports Composer v1, this issue tracks the removal of all Composer v1-specific code, including feature flags associated with its deprecation and unsupported status (composer_v1_deprecation_warning and composer_v1_unsupported_error). This cleanup will ensure that only Composer v2 and higher versions are supported moving forward.

Removal process: Following steps were performed to remove the support for v1

  1. Delete v1 folder (composer/helpers/v1) which removes all references to V1 code.
  2. Adjust docker file composer/Dockerfile to remove the reference to v1 code.
  3. Remove all test cases related to v1 in from spec.rb files.
  4. Remove the feature flags composer_v1_deprecation_warning, composer_v1_unsupported_error and adjust the code accordingly.
  5. Adjust new test cases related to V2 by dropping reference to feature flag and making changes accordingly.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Nov 14, 2024
@github-actions github-actions bot added the L: php:composer Issues and code for Composer label Nov 14, 2024
@sachin-sandhu sachin-sandhu marked this pull request as ready for review November 14, 2024 16:51
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner November 14, 2024 16:51
@abdulapopoola
Copy link
Member

This PR doesn't include the removal of the v1 folder, will that be in a separate PR?

@sachin-sandhu
Copy link
Contributor Author

@abdulapopoola , Had some issues pushing v1 delete changes , pushed them now.

@abdulapopoola
Copy link
Member

In a separate PR to avoid bloating up this PR, we should look at renaming the v2 folder too since that is the only version left.

Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Other then that looks good to me.

@sachin-sandhu sachin-sandhu force-pushed the batch-remove-composer-v1-code-and-related-feature-flags branch from 9600e75 to bb4b5c7 Compare November 14, 2024 20:51
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-sandhu sachin-sandhu merged commit 1c65ca1 into main Nov 14, 2024
75 checks passed
@sachin-sandhu sachin-sandhu deleted the batch-remove-composer-v1-code-and-related-feature-flags branch November 14, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: php:composer Issues and code for Composer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants