only report a package as existing if the actual .nupkg can be downloaded
#10939
+151
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-analyze
branch
from
6de2823
to
d129560
Compare
JamieMagee
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if a newer package exists, we previously only checked the NuGet endpoint to see if the version is reported. This doesn't necessarily work with an authenticated Azure DevOps feed because the version could be reported as existing, but actually attempting to download the
.nupkgcould fail because the current authentication isn't allowed to pull in the upstream package.The fix is to try to actually download the package before we report it as a possible upgrade path.
This issue was found by manually scanning the logs from the
nuget_native_analysisexperiment.