Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DiscoveryWorker project path check case insensitive #10958

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

sebasgomez238
Copy link
Contributor

@sebasgomez238 sebasgomez238 commented Nov 18, 2024

What are you trying to accomplish?

Make file check in DiscoveryWorker case insensitive. This allows projects referenced from solution files to be found even if the case of the file path is different.

Currently we have issues where a .sln file references a project found on disk but we fail to discover it because the casing is different.

Fixes #10957

Anything you want to highlight for special attention from reviewers?

The approach taken was to crawl our way through the directories while and looking for matching names on each section while ignoring casing differences.

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Nov 18, 2024
@sebasgomez238 sebasgomez238 marked this pull request as ready for review November 19, 2024 16:14
@sebasgomez238 sebasgomez238 requested a review from a team as a code owner November 19, 2024 16:14
@sebasgomez238 sebasgomez238 changed the title Add test for case insensitivity Make DiscoveryWorker project path check case insensitive Nov 19, 2024
@randhircs randhircs force-pushed the users/segomez/handle-casing-issues branch from 0d36619 to 15c8b7d Compare November 19, 2024 18:58
@randhircs randhircs merged commit 3ef842c into main Nov 19, 2024
70 checks passed
@randhircs randhircs deleted the users/segomez/handle-casing-issues branch November 19, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference in casing in .sln file can cause project not to be discovered
3 participants