Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for docker-compose.yml files. #1862

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oceanBT
Copy link

@oceanBT oceanBT commented May 17, 2020

All credits goes to @pedropombeiro! I just reopend his PR. See original PR #1431 for more details.

Fix #390

@@ -69,8 +69,8 @@ def version_up_to_date?
# If the tag isn't up-to-date then we can definitely update
return false if version_tag_up_to_date? == false

# Otherwise, if the Dockerfile specifies a digest check that that is
# up-to-date
# Otherwise, if the Dockerfile/docker-compose.yml specifies a digest

This comment was marked as resolved.

@feelepxyz feelepxyz changed the base branch from master to main June 24, 2020 11:25
@JeffResc
Copy link

JeffResc commented Oct 8, 2020

Any update on this? Looks like it's been a pending PR for two years now...

@jurre jurre added the T: new-ecosystem Requests for new ecosystems/languages label Nov 30, 2021
@maxekman
Copy link

Any update on this? Would love to have support for Docker Compose updates. Currently we have to resort to https://github.com/renovatebot/renovate for this.

@jeffwidman jeffwidman changed the title Add support for docker-compose.yml files. Closes dependabot/dependabot-core#390 Add support for docker-compose.yml files. Sep 15, 2022
@jeffwidman
Copy link
Member

jeffwidman commented Sep 17, 2022

👋 Sorry for the delayed response.

The reason it's "floating" is that we're currently not accepting new ecosystems, but we're also not planning for that to be true forever. So PR's adding new ecosystems are currently on-pause. Once we have the capacity to support new ecosystems, then we plan to go through some of these PR's evaluating them on case-by-case basis.

@jeffwidman jeffwidman added on-hold 🛑 Feature is proposed but hasn't been scheduled T: new-ecosystem Requests for new ecosystems/languages and removed T: new-ecosystem Requests for new ecosystems/languages labels Sep 17, 2022
@netsandbox
Copy link

@jeffwidman this PR doesn't add a new ecosytem, it just improves a existing docker ecosystem by adding support for a commonly used file where docker images are defined.

So it would be great if you can check again if this PR should be on hold because of the "currently not accepting new ecosystems" policy.

@Fuochi
Copy link

Fuochi commented Dec 14, 2022

👋 Sorry for the delayed response.

The reason it's "floating" is that we're currently not accepting new ecosystems, but we're also not planning for that to be true forever. So PR's adding new ecosystems are currently on-pause. Once we have the capacity to support new ecosystems, then we plan to go through some of these PR's evaluating them on case-by-case basis.

Hi @jeffwidman
Few months ago, PR #5348 has been accepted. It is very similar, at least in concept, to this one. Does that mean that a PR for docker compose can be taken into consideration now?

@yeikel
Copy link
Contributor

yeikel commented Apr 17, 2023

@jeffwidman Is there any chance you can reconsider the label for this change?

I also agree with the previous sentiment that this is not a new ecosystem. This change enhances the existing support for docker as docker compose files are effectively part of the same docker ecosystem

@jeffwidman
Copy link
Member

@jeffwidman Is there any chance you can reconsider the label for this change?

I also agree with the previous sentiment that this is not a new ecosystem. This change enhances the existing support for docker as docker compose files are effectively part of the same docker ecosystem

Let's have that discussion on the associated issue, and keep the discussion on this PR about implementation details if/when we're ready to pull it in.

On that note, I posted my thoughts on the topic over in that ticket here:
#390 (comment)

@port19x
Copy link

port19x commented Aug 24, 2023

Does anybody know if it is possible to use this fork and how?
I see that dependabot.yml includes a version field, but I don't think I can just point to this branch with that.
Disappointing that this takes several years to merge.

@fetwar
Copy link

fetwar commented Jan 17, 2024

Is there a way we can help out with this PR?

What can we do to get this change that is highly sought after since 2018 and in review and put on hold multiple times since 2019 off the ground?

I would love to use this feature as would so many others. Supporting Docker but not Docker Compose means so many workflows are broken and the available workarounds either mean migrating from this tool entirely, or breaking the image pulling without building functionality in existing codebases provided by Docker Compose.


Potential Ideas

  • Provide a list of tasks or other blocking jobs that could aide the PR in being reviewed for the community to pitch in and help with.
  • Allow as an experimental or beta feature, or document as being a work in progress, which allows the minimum viable product to still be used and tested by others.
  • Seek additional maintainers to lessen the workload and prevent review from blocking PRs for years at a time

These are just some quick notes, all with the best intentions, all responses are welcome

@xenago
Copy link

xenago commented Jun 4, 2024

Any status update on this? Support for Docker but not compose remains a large gap

@fetwar
Copy link

fetwar commented Jun 7, 2024

Since commenting I've switched to using Mend Renovate instead, it is night and day better than dependabot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold 🛑 Feature is proposed but hasn't been scheduled T: new-ecosystem Requests for new ecosystems/languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Docker compose files