-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for docker-compose.yml files. #1862
base: main
Are you sure you want to change the base?
Conversation
@@ -69,8 +69,8 @@ def version_up_to_date? | |||
# If the tag isn't up-to-date then we can definitely update | |||
return false if version_tag_up_to_date? == false | |||
|
|||
# Otherwise, if the Dockerfile specifies a digest check that that is | |||
# up-to-date | |||
# Otherwise, if the Dockerfile/docker-compose.yml specifies a digest |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Any update on this? Looks like it's been a pending PR for two years now... |
Any update on this? Would love to have support for Docker Compose updates. Currently we have to resort to https://github.com/renovatebot/renovate for this. |
👋 Sorry for the delayed response. The reason it's "floating" is that we're currently not accepting new ecosystems, but we're also not planning for that to be true forever. So PR's adding new ecosystems are currently on-pause. Once we have the capacity to support new ecosystems, then we plan to go through some of these PR's evaluating them on case-by-case basis. |
@jeffwidman this PR doesn't add a new ecosytem, it just improves a existing So it would be great if you can check again if this PR should be on hold because of the "currently not accepting new ecosystems" policy. |
Hi @jeffwidman |
@jeffwidman Is there any chance you can reconsider the label for this change? I also agree with the previous sentiment that this is not a new ecosystem. This change enhances the existing support for docker as docker compose files are effectively part of the same docker ecosystem |
Let's have that discussion on the associated issue, and keep the discussion on this PR about implementation details if/when we're ready to pull it in. On that note, I posted my thoughts on the topic over in that ticket here: |
Does anybody know if it is possible to use this fork and how? |
Is there a way we can help out with this PR? What can we do to get this change that is highly sought after since 2018 and in review and put on hold multiple times since 2019 off the ground? I would love to use this feature as would so many others. Supporting Docker but not Docker Compose means so many workflows are broken and the available workarounds either mean migrating from this tool entirely, or breaking the image pulling without building functionality in existing codebases provided by Docker Compose. Potential Ideas
These are just some quick notes, all with the best intentions, all responses are welcome |
Any status update on this? Support for Docker but not compose remains a large gap |
Since commenting I've switched to using Mend Renovate instead, it is night and day better than dependabot |
All credits goes to @pedropombeiro! I just reopend his PR. See original PR #1431 for more details.
Fix #390