Add support for disablePackageSources in NuGet.Config #3296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents disabled package sources, such as those used for doing deploys to private package registries, from being used. #3295
jurre
reviewed
Mar 18, 2021
|
Looks good 👍 I made one small suggestion inline |
- As suggested, `repos_from_config_file()` was getting too long, so pull the disabled sources parsing into its own method. - Reenable the MethodLength metric for `repos_from_config_file()`. - Includes a small optimization by @jurre. Co-Authored-By: Jurre <jurre@users.noreply.github.com>
jurre
approved these changes
Mar 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents disabled package sources, such as those used for doing deploys to private package registries, from being used.
Will read, and disable, any repositories specified in
disabledPackageSourcesinNuGet.Config, for example, the followinggithubpackage source will not be used:https://docs.microsoft.com/en-us/nuget/reference/nuget-config-file#disabledpackagesources
Though I haven't tested, I strongly suspect that without this change, if a disabled source has a newer dependency version, that the PR dependabot creates would fail to build.Edit: Confirmed, does trigger the bug, see AshleighAdams/dependabot-bug-poc#1
Fix #3295