Bundler 2: [Prerelease] Add native helpers for file parsing #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codisart
reviewed
Mar 22, 2021
feelepxyz
changed the title
feelepxyz
changed the title
feelepxyz
changed the title
feelepxyz
commented
Mar 22, 2021
| - python | ||
| - terraform | ||
| - { path: bundler, name: bundler1 } | ||
| - { path: bundler, name: bundler2 } |
There was a problem hiding this comment.
Ah, the only downside of this approach is it seems to mess with our configured required builds, we'll need to flip the required builds from the old set to the new ones, merge this and then force all other PRs to merge master.
Not a big deal overall, as I think this is ultimately a better approach, just a one-time pain to switch over.
There was a problem hiding this comment.
Good catch! Will fix that up 👍
jurre
reviewed
Mar 22, 2021
| @@ -20,4 +19,5 @@ cd "$install_dir" | |||
|
|
|||
| # NOTE: Sets `BUNDLED WITH` to match the installed v1 version in Gemfile.lock | |||
| # forcing specs and native helpers to run with the same version | |||
| BUNDLER_VERSION=2 bundle install | |||
| BUNDLER_VERSION=2 bundle config set --local path ".bundle" | |||
jurre
reviewed
Mar 22, 2021
jurre
approved these changes
Mar 22, 2021
feelepxyz
force-pushed
the
feelepxyz/bundler2-file-parser
branch
from
c793e11 to
1975d59
Compare
brrygrdn
approved these changes
Mar 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add native helpers for bundler 2 file parsing with testing setup to run bundler specs with both bundler 1 and 2.
The current setup runs all bundler tests twice, sequentially which will add around ~4 mins to the bundler test suite run time.
We could split and run these in parallel or make the bundler 2 tests optional somehow but this also complicates the test setup.