Python: Quarantine slow tests into their own CI run #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
force-pushed
the
jurre/quarantine-slow-tests
branch
from
59dd888 to
e0bdf7a
Compare
brrygrdn
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
I like this approach, I think it's a really pragmatic way to deal with the issue 👍🏻
I also think this is a better approach than using a build-matrix balancing rspec extension as that would just result in us running an increasingly large number of workers in parallel which doesn't get to the root of the problem.
These tests have not been wearing masks, and to avoid them infecting the other tests we need to quarantine them. Jokes aside, splitting these slow tests off into their own CI run should reduce the overall time we have to wait on CI to pass, and it gives us some indication on which tests we might want to try to speed up going forward. So far I've split off the ~10 slowest tests, which according to rspec take 40% of the total time to run these tests! We can move more things into the slow suite, but I'd like to avoid having the majority of the tests live there, because then we'd still end up with one very slow suite.
jurre
force-pushed
the
jurre/quarantine-slow-tests
branch
from
e0bdf7a to
c1f62e8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests have not been wearing masks, and to avoid them infecting the
other tests we need to quarantine them.
Jokes aside, splitting these slow tests off into their own CI run should
reduce the overall time we have to wait on CI to pass, and it gives us
some indication on which tests we might want to try to speed up going
forward.
So far I've split off the ~10 slowest tests, which according to rspec
take 40% of the total time to run these tests!
We can move more things into the slow suite, but I'd like to avoid
having the majority of the tests live there, because then we'd still end
up with one very slow suite.