Include ecosystem name in job summary #6535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed in https://github.com/dependabot/dependabot-core/actions/runs/4034930902/attempts/1 that the docker image names are missing the ecosystem name. So I added it, by copying the format from the step above where we're building the `dependabot-updater image`. I double-checked, and the summaries for `eco-branch-images.yml` and the similar action for forks already include this in their job summary: https://github.com/dependabot/dependabot-core/blob/5eff30823a1eb0aba02f2267d14427a8bb547414/.github/workflows/eco-branch-images.yml#L99
deivid-rodriguez
approved these changes
Jan 29, 2023
alcere
pushed a commit
that referenced
this pull request
Feb 20, 2023
I noticed in https://github.com/dependabot/dependabot-core/actions/runs/4034930902/attempts/1 that the docker image names are missing the ecosystem name. So I added it, by copying the format from the step above where we're building the `dependabot-updater image`. I double-checked, and the summaries for `eco-branch-images.yml` and the similar action for forks already include this in their job summary: https://github.com/dependabot/dependabot-core/blob/5eff30823a1eb0aba02f2267d14427a8bb547414/.github/workflows/eco-branch-images.yml#L99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in https://github.com/dependabot/dependabot-core/actions/runs/4034930902/attempts/1 that the docker image names are missing the ecosystem name. Having this correct makes it easier to update smoke tests, for example I had to copy the full image name when doing dependabot/smoke-tests#27.
So I added it, by copying the format from the step above where we're building the
dependabot-updater image:dependabot-core/.github/workflows/eco-latest-releases.yml
Lines 90 to 91 in 5eff308
I double-checked, and the summaries for
eco-branch-images.ymland the similar action for forks already include this in their job summary:dependabot-core/.github/workflows/eco-branch-images.yml
Line 99 in 5eff308