Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3.6 guard when setting poetry config experimental.system-git-client #7614

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

jeffwidman
Copy link
Member

@jeffwidman jeffwidman commented Jul 22, 2023

Depends on:

We no longer support Python 3.6, so this now always needs to happen.

I also bumped the minimum version of poetry up to 1.2 as that's when
the flag was added. It shouldn't matter, as python will default to the
highest version allowed by that version of python, and now that we only
support 3.7 onwards that will be the upper bound.

@jeffwidman jeffwidman changed the title Remove 3.6 conditional in poetry config setting Remove 3.6 guard when setting poetry config experimental.system-git-client Jul 22, 2023
@jeffwidman jeffwidman force-pushed the no-need-to-protect-against-python-3.6 branch 2 times, most recently from 9d06eba to 7627af9 Compare July 22, 2023 08:13
@jeffwidman jeffwidman added the Ecosystems Used by the maintainer team for internal-facing project tracking label Jul 24, 2023
@jeffwidman jeffwidman self-assigned this Jul 24, 2023
@jeffwidman jeffwidman force-pushed the no-need-to-protect-against-python-3.6 branch 3 times, most recently from d4f5d48 to ca57965 Compare August 2, 2023 23:30
@jeffwidman jeffwidman added L: elixir:hex Elixir packages via hex and removed L: python labels Aug 3, 2023
@jeffwidman jeffwidman force-pushed the no-need-to-protect-against-python-3.6 branch from ca57965 to 6361996 Compare August 4, 2023 18:58
@github-actions github-actions bot added L: python and removed L: elixir:hex Elixir packages via hex labels Aug 4, 2023
@jeffwidman jeffwidman force-pushed the no-need-to-protect-against-python-3.6 branch from 6361996 to ee2c232 Compare August 10, 2023 00:13
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This "fixes" #5809.

@jeffwidman jeffwidman marked this pull request as ready for review August 17, 2023 05:41
@jeffwidman jeffwidman requested a review from a team as a code owner August 17, 2023 05:41
…t-client`

We no longer support Python 3.6, so this now always needs to happen.

I also bumped the minimum version of `poetry` up to `1.2` as that's when
the flag was added. It shouldn't matter, as python will default to the
highest version allowed by that version of python, and now that we only
support `3.7` onwards that will be the upper bound.
@jeffwidman jeffwidman force-pushed the no-need-to-protect-against-python-3.6 branch from ee2c232 to fb965af Compare August 17, 2023 05:42
@jeffwidman jeffwidman enabled auto-merge (squash) August 17, 2023 05:44
@jeffwidman
Copy link
Member Author

Good memory! I'd completely forgotten about that issue/PR.

@jeffwidman jeffwidman merged commit 285744f into main Aug 17, 2023
90 checks passed
@jeffwidman jeffwidman deleted the no-need-to-protect-against-python-3.6 branch August 17, 2023 06:06
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
…t-client` (dependabot#7614)

We no longer support Python 3.6, so this now always needs to happen.

I also bumped the minimum version of `poetry` up to `1.2` as that's when
the flag was added. It shouldn't matter, as python will default to the
highest version allowed by that version of python, and now that we only
support `3.7` onwards that will be the upper bound.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ecosystems Used by the maintainer team for internal-facing project tracking L: python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants