fixes toolchain directive getting into go.mod #7884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landongrindheim
approved these changes
Aug 23, 2023
Co-authored-by: Landon Grindheim <landon.grindheim@gmail.com>
1 task
vincentbernat
added a commit
to vincentbernat/dependabot-core
that referenced
this pull request
Sep 6, 2023
Due to a bug in Go 1.20 (see golang/go#61873), when importing a module without a dot in it, we get: ``` 18:13 ❱ GOTOOLCHAIN="go1.20+auto" go get akvorado: ambiguous import: found package akvorado in multiple modules: akvorado (/home/bernat/code/free/akvorado) (/home/bernat/src/gocode/pkg/mod/golang.org/toolchain@v0.0.1-go1.20.linux-amd64/src/akvorado) ``` This issue was fixed in Go 1.20.8 which was just released. By using `go1.20.8` as a toolchain for anything <= 1.20, we still cover the use case introduced in dependabot#7884, but we also avoid this bug. `go1.20.8` is a valid toolchain. For Go 1.20, only `go1.20` is a valid version for `go` directive in `go.mod`.
jakecoffman
pushed a commit
that referenced
this pull request
Sep 6, 2023
Due to a bug in Go 1.20 (see golang/go#61873), when importing a module without a dot in it, we get: ``` 18:13 ❱ GOTOOLCHAIN="go1.20+auto" go get akvorado: ambiguous import: found package akvorado in multiple modules: akvorado (/home/bernat/code/free/akvorado) (/home/bernat/src/gocode/pkg/mod/golang.org/toolchain@v0.0.1-go1.20.linux-amd64/src/akvorado) ``` This issue was fixed in Go 1.20.8 which was just released. By using `go1.20.8` as a toolchain for anything <= 1.20, we still cover the use case introduced in #7884, but we also avoid this bug. `go1.20.8` is a valid toolchain. For Go 1.20, only `go1.20` is a valid version for `go` directive in `go.mod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7868
I had to read https://tip.golang.org/doc/toolchain#select a few times to understand this so let me summarize:
With
GOTOOLCHAINunset, Go 1.21 will use the locally installed toolchain (1.21.0 currently) if the go directive is <= 1.21. This means it was injecting the new toolchain directive and updating the go directive to 1.21 in oldergo.mods, but Dependabot code reverts the change to the go directive, which is how we ended up with #7868. This only affected go.mod files that had dependencies that were on 1.21.By switching to
GOTOOLCHAIN="go1.20+auto"we revert to using Go 1.20 to retain the current behavior forgo.modwith go directive <=1.20, but theautomeans anygo.modthat are on newer versions will automatically select the right Go toolchain and download it if not installed locally.Thus technically this is the last bump we ever need to do with the Go version. Although to prevent each job from downloading the Go toolchain on-the-fly we can pre-install multiple popular versions.