allow flamegraph gathering #9423
Conversation
|
When I was looking into this it seemed stackprof could generate flamegraphs itself, though that required a command run on the shell against a profile. I wonder if it might be useful though to get both the raw profile and the flamegraph? I'm not sure what else we could do with raw profile data so it probably makes sense to just get the flamegraph for now. |
| @@ -35,6 +35,9 @@ gem "sentry-opentelemetry", "~> 5.16" | |||
| gem "sentry-ruby", "~> 5.16" | |||
| gem "terminal-table", "~> 3.0.2" | |||
|
|
|||
| gem "flamegraph", "~> 0.9.5" | |||
| gem "stackprof", "~> 0.2.16" | |||
There was a problem hiding this comment.
FYI this is already in common, since we have the functionality in the dry-run script:
There was a problem hiding this comment.
Do you recommend I remove it here and switch that line in common to be spec.add_dependency?
|
I want to move forward with this so I can continue debugging issues. We can refine how this is defined in the gemspecs/Gemfile and how the flamegraph is actually generated, feel free to improve on it going forward or let me know and I can make more PRs! |
To debug customer performance issues, this adds the ability to request a flamegraph be generated.
The CLI PR that will enable this is dependabot/cli#299.
I tested this with the command
dependabot update bundler dependabot/dependabot-core --directory updater --flamegraph --dep vcrand it produced a nice flamegraph!