fix(tsConfig): path mapping by filing-cabinet

[jjangga0214]

The PR pending in filing-cabinet(dependents/node-filing-cabinet#100) should be merged and published before this PR to be merged.

I personally tested this PR against https://github.com/jjangga0214/ts-yarn-lerna-boilerplate, with filing-cabinet patched by dependents/node-filing-cabinet#100.

Closes #135

Related to:

• feat(tsLookup): path mapping node-filing-cabinet#100
• fix(tsconfig): respect path mapping #136

Thanks!

[jjangga0214]

@mrjoelkemp Hi!
Thank you for merging dependents/node-filing-cabinet#100.
Now, this transitive PR is ready to be merged as well!
Thanks!

[jjangga0214]

@mrjoelkemp Hi!
Would you mind if I ping you?
I wish this PR to be merged as I want to depend on node-dependency-tree from my new library, with this PR's feature.
Thanks a lot in advance!

[XhmikosR]

Please rebase, drop any unneeded changes and make sure lint + tests pass.

[tianyingchun]

how progress of this issue?

[jjangga0214]

@tianyingchun I will do it this week :)

[jjangga0214]

@XhmikosR @tianyingchun Done it :)

[tianyingchun]

Waiting new release

[XhmikosR]

A test is still needed.

[jjangga0214]

Should we add a test for cases like this as well?
I'd respect your decision, but I don't think so personally, IMHO.
This change is just a passing of a new single option to filing-cabinet.
Even if there's a bug or inconsistency, it's not what node-dependency-tree should find out and fix.
It's a dependency's job, by separation of concern and separated responsibility.
The test is already created on filing-cabinet's side, and should I recreate almost the same test case for the same purpose?
What do you think?
Thanks :)

[tianyingchun]

why we need two typescript config here?

tsConfig: config.tsConfig
tsConfigPath: config.tsConfigPath

Should we make tsConfig (string/object) works correct? instead of add new option tsConfigPath? Very difficult to understand

[jjangga0214]

@tianyingchun I'd like to recommend reading this PR :)

[jjangga0214]

@XhmikosR May I ping?

Thanks :)

[jjangga0214]

@XhmikosR Hi? Are you super busy these days?

Thanks :)

[jjangga0214]

@XhmikosR Hello, dear maintainers!
This PR was ready-to-be-merged, but ignored for a long time and new commits came into the main branch, which is somewhat questionable. May I request more attention?

[miluoshi]

Hi, can the be moved forward please? 🙏

[XhmikosR]

I don't have time for dependents and I still think this needs a test case.

[miluoshi]

@jjangga0214 can you write tests for the new option please?

[rhyek]

Really disappointed this isn't merged, yet. Kind of pointless use this lib with a TypeScript project as it is, since path mapping is very common.