Fix resolving js imports that have same-named ".d.ts" from ts with 'noTypeDefinitions' set to true #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
If
.d.ts
exists,ts
resolve import as the path to the type-definition file by default (instead of the js file).But if we set the
noTypeDefinitions
flag to true,we pass the unresolved import path to the
ts.resolveJSModule
.And if we have a type alias:
our unresolved import looks like
instead of
Therefore
ts
cannot resolve this import and fails with an error.Solution:
Pass to the
ts.resolveJSModule
resolved path of the import without extension.Relates to: #112