Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack roots #120

Merged
merged 3 commits into from
May 7, 2023
Merged

fix: webpack roots #120

merged 3 commits into from
May 7, 2023

Conversation

SyMind
Copy link
Contributor

@SyMind SyMind commented May 6, 2023

  1. resolve.root maybe a string, used in webpack 1.x.
    more detail here: resolve.root vs moduleDirectories webpack/webpack#472 (comment)

  2. resolve.roots is used in latest webpack.
    webpack docs: https://webpack.js.org/configuration/resolve/#resolveroots

@SyMind
Copy link
Contributor Author

SyMind commented May 6, 2023

@XhmikosR cc

@XhmikosR
Copy link
Member

XhmikosR commented May 6, 2023

Please revert the test change and add a new one.

@SyMind
Copy link
Contributor Author

SyMind commented May 6, 2023

Please revert the test change and add a new one.

@XhmikosR done

@XhmikosR XhmikosR merged commit d563f18 into dependents:main May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants