Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read local configuration file recursively from current working directory #18

Closed
98sean98 opened this issue Jun 30, 2022 · 3 comments · Fixed by #21
Closed

read local configuration file recursively from current working directory #18

98sean98 opened this issue Jun 30, 2022 · 3 comments · Fixed by #21
Assignees
Labels
enhancement New feature or request summer 22 Summer 2022 project

Comments

@98sean98
Copy link
Contributor

When a user is inside the subdirectories of a project, the user should still be able to use the deploifai cli with all its configuration. That means the cli runtime needs to be able to traverse up the directory tree to find the nearest .deploifai to get the local configuration file.

@98sean98 98sean98 added enhancement New feature or request summer 22 Summer 2022 project labels Jun 30, 2022
@Richard-B18 Richard-B18 self-assigned this Jun 30, 2022
@Richard-B18
Copy link
Contributor

Richard-B18 commented Jul 4, 2022

might be overthinking this issue, but how to make sure user creates local config file in the root directory of the project?

project/.deploifai/local_config.py

what if user does sth like deploifai project create in the project/data or other child directories

@Richard-B18
Copy link
Contributor

Richard-B18 commented Jul 4, 2022

or is this not possible since local config file can only be created when user first initialized a project locally?

@Richard-B18
Copy link
Contributor

I think issue is not only reading local config

Assuming my above assumption, and user's local config file is in the right directory which is directly under the initialized project directory, this means that both global and local config file should only be initialized once (unless user deletes it, but we assume this won't happen for now)

this means that whenever a user saves something to the local config file, if user is not in the root project dir, it will create another folder according to how the code works right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request summer 22 Summer 2022 project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants