Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local config: both read and write issue if user is not in the right dir #21

Merged
merged 30 commits into from
Jul 7, 2022

Conversation

Richard-B18
Copy link
Contributor

No description provided.

@Richard-B18 Richard-B18 requested a review from 98sean98 July 5, 2022 03:54
@Richard-B18 Richard-B18 linked an issue Jul 5, 2022 that may be closed by this pull request
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are still some necessary changes.

deploifai/project/create.py Outdated Show resolved Hide resolved
deploifai/project/create.py Outdated Show resolved Hide resolved
deploifai/project/create.py Outdated Show resolved Hide resolved
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug in code in line 149 of project/create.py with the raise abort.

Richard-B18 and others added 6 commits July 7, 2022 15:33
* support gcp for the feature, added some enums, minor bug fix

* Project create command (#16)

* enable create command

* prompt workspace and query cloud profile in create command

* calls backend graphql api to createProject

* fix minor bugs of wrong api call, add some msg after api call

* add a validation for project name

* move cli msg to command callback instead of during api calling, minor bug fix

* push everything

* add is_authenticated decorator and refactor to use graphql fragments

* bump package version to 0.1.2

* refractor auth checking, minor bug fix

Co-authored-by: Sean Chok <seanchok@gmail.com>

* gcp cloud profile creation, refractor auth checking

* parse gcp key json file as string

* rm unnecessary imports

* Project Browse Command (#19)

* Project Browse Command

Adding project browse command to cli and get_workspace function to api

* Changes

Improved the browse and get project function

* final refactor and test

* bump package version to 0.1.3

Co-authored-by: Sean Chok <seanchok@gmail.com>

* refractor cloud profile creation

* change app structure for cloud profile creation

* minor bug fix on passing variables for querying graphql

* minor bug fix

* minor issue

Co-authored-by: Sean Chok <seanchok@gmail.com>
Co-authored-by: ExtinctWolf83 <89630581+ExtinctWolf83@users.noreply.github.com>
@Richard-B18 Richard-B18 merged commit 8abb209 into main Jul 7, 2022
@Richard-B18 Richard-B18 deleted the local-config branch July 7, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read local configuration file recursively from current working directory
2 participants