project command: create cloud profile #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Umm you're gonna have to do some rebasing against the main branch |
Richard-B18
commented
Jul 1, 2022
Richard-B18
force-pushed
the
project-create
branch
from
b225670
to
b78f062
Compare
* enable create command * prompt workspace and query cloud profile in create command * calls backend graphql api to createProject * fix minor bugs of wrong api call, add some msg after api call * add a validation for project name * move cli msg to command callback instead of during api calling, minor bug fix * push everything * add is_authenticated decorator and refactor to use graphql fragments * bump package version to 0.1.2 * refractor auth checking, minor bug fix Co-authored-by: Sean Chok <seanchok@gmail.com>
* Project Browse Command Adding project browse command to cli and get_workspace function to api * Changes Improved the browse and get project function * final refactor and test * bump package version to 0.1.3 Co-authored-by: Sean Chok <seanchok@gmail.com>
Richard-B18
force-pushed
the
project-create
branch
from
b78f062
to
bdb6ee9
Compare
98sean98
requested changes
Jul 6, 2022
There was a problem hiding this comment.
The project create command shouldn't involve any cloud profile creation, the user should just choose an existing cloud profile. If they don't have any cloud profiles to begin with, the project create command should just raise an abort.
They should also manage cloud profiles through a new group of commands called cloud-profile, and create a new cloud profile with cloud-profile create, see #20
98sean98
reviewed
Jul 7, 2022
98sean98
requested changes
Jul 7, 2022
98sean98
approved these changes
Jul 7, 2022
Richard-B18
added a commit
that referenced
this pull request
Jul 7, 2022
…ir (#21) * minor refractor on global config * traverse up recursively and read config file if in child dir of client's project dir * refractor local config file manager * minor typo * WIP * change flow of project create command, minor refractor in local config * change flow of cli, if project not found, set local config to none instead * bug fix when user initializes a project * change flow of command, create project locally b4 doing it in the backend * refractor for commands using local config * added a decorator to check if deploifai project found * change flow of commmand again, bug fix for duplicate local file names * change command flow, no more loops if invalid name * minor bug fix * project command: create cloud profile (#17) * support gcp for the feature, added some enums, minor bug fix * Project create command (#16) * enable create command * prompt workspace and query cloud profile in create command * calls backend graphql api to createProject * fix minor bugs of wrong api call, add some msg after api call * add a validation for project name * move cli msg to command callback instead of during api calling, minor bug fix * push everything * add is_authenticated decorator and refactor to use graphql fragments * bump package version to 0.1.2 * refractor auth checking, minor bug fix Co-authored-by: Sean Chok <seanchok@gmail.com> * gcp cloud profile creation, refractor auth checking * parse gcp key json file as string * rm unnecessary imports * Project Browse Command (#19) * Project Browse Command Adding project browse command to cli and get_workspace function to api * Changes Improved the browse and get project function * final refactor and test * bump package version to 0.1.3 Co-authored-by: Sean Chok <seanchok@gmail.com> * refractor cloud profile creation * change app structure for cloud profile creation * minor bug fix on passing variables for querying graphql * minor bug fix * minor issue Co-authored-by: Sean Chok <seanchok@gmail.com> Co-authored-by: ExtinctWolf83 <89630581+ExtinctWolf83@users.noreply.github.com> * minor refractor on global config * traverse up recursively and read config file if in child dir of client's project dir * refractor local config file manager * minor typo * WIP * change flow of project create command, minor refractor in local config * change flow of cli, if project not found, set local config to none instead * bug fix when user initializes a project * change flow of command, create project locally b4 doing it in the backend * refractor for commands using local config * added a decorator to check if deploifai project found * change flow of commmand again, bug fix for duplicate local file names * change command flow, no more loops if invalid name * minor bug fix Co-authored-by: Sean Chok <seanchok@gmail.com> Co-authored-by: ExtinctWolf83 <89630581+ExtinctWolf83@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.