Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset create #24

Merged
merged 10 commits into from
Jul 12, 2022
Merged

Dataset create #24

merged 10 commits into from
Jul 12, 2022

Conversation

ExtinctWolf83
Copy link
Contributor

No description provided.

@ExtinctWolf83 ExtinctWolf83 self-assigned this Jul 6, 2022
@ExtinctWolf83 ExtinctWolf83 linked an issue Jul 6, 2022 that may be closed by this pull request
@ExtinctWolf83 ExtinctWolf83 added the summer 22 Summer 2022 project label Jul 6, 2022
@ExtinctWolf83 ExtinctWolf83 marked this pull request as ready for review July 8, 2022 10:51
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes.

deploifai/data/create.py Outdated Show resolved Hide resolved
deploifai/data/create.py Outdated Show resolved Hide resolved
@ExtinctWolf83 ExtinctWolf83 linked an issue Jul 11, 2022 that may be closed by this pull request
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a fix in the project_found decorator

@@ -147,7 +147,7 @@ def project_found(f):
@pass_context
def wrapper(click_context, *args, **kwargs):
deploifai_context = click_context.find_object(DeploifaiContextObj)
if deploifai_context.local_config is not None:
if deploifai_context.local_config["PROJECT"]["id"] is not None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might throw a KeyError when trying to access a key that doesn't exist in the dictionary. So maybe check using if 'id' in ...

@98sean98 98sean98 merged commit b9a39d6 into main Jul 12, 2022
@98sean98 98sean98 deleted the dataset-create branch July 12, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
summer 22 Summer 2022 project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix project_found decorator Create dataset command
2 participants