Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list commands to project, cloud profile, dataset #36

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Add list commands to project, cloud profile, dataset #36

merged 5 commits into from
Jul 21, 2022

Conversation

ExtinctWolf83
Copy link
Contributor

No description provided.

This was linked to issues Jul 18, 2022
fix project browse command url routing #34
Closed
Add a list commands to project, cloud profile, data storage, and training server commands #35
Closed
@ExtinctWolf83 ExtinctWolf83 self-assigned this Jul 18, 2022
@ExtinctWolf83 ExtinctWolf83 added bug Something isn't working enhancement New feature or request summer 22 Summer 2022 project labels Jul 18, 2022
@98sean98 98sean98 changed the title Added list functions as required Add list commands to project, cloud profile, dataset Jul 18, 2022
98sean98
98sean98 reviewed Jul 18, 2022
View reviewed changes
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing some necessary changes using the whereProject argument queries for data storages querying in the dataset list command

deploifai/cloud_profile/list.py Outdated Show resolved Hide resolved
deploifai/data/list.py Outdated Show resolved Hide resolved
deploifai/data/list.py Outdated Show resolved Hide resolved
@ExtinctWolf83 ExtinctWolf83 marked this pull request as ready for review July 19, 2022 11:02
98sean98
98sean98 requested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes.

deploifai/dataset/list.py Outdated Show resolved Hide resolved
deploifai/server/list.py Outdated Show resolved Hide resolved
deploifai/api/__init__.py Outdated Show resolved Hide resolved
deploifai/api/__init__.py Outdated Show resolved Hide resolved
deploifai/dataset/list.py Outdated Show resolved Hide resolved
deploifai/server/list.py Outdated Show resolved Hide resolved
@ExtinctWolf83 ExtinctWolf83 merged commit eccd5e9 into main Jul 21, 2022
@ExtinctWolf83 ExtinctWolf83 deleted the list-command branch July 21, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@98sean98 98sean98 98sean98 approved these changes

Assignees

@ExtinctWolf83 ExtinctWolf83

Labels
bug Something isn't working enhancement New feature or request summer 22 Summer 2022 project
Projects
None yet
Milestone
No milestone
2 participants
@ExtinctWolf83 @98sean98