Skip to content

reorganized the ClientOptions in ther Go HTTP client code to reflect … #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

ShocOne
Copy link
Contributor

@ShocOne ShocOne commented Apr 25, 2024

…a more structured and thematic grouping of related configuration settings

Change

Reorganised the ClientOptions in the Go HTTP client code to reflect a more structured and thematic grouping of related configuration settings. Each nested configuration under ClientOptions now represents a specific area of the HTTP client functionality—logging, cookie handling, retry behaviour, concurrency management, timeout settings, and redirect handling. This structure improves readability, makes the configuration easier to maintain, and allows developers to quickly understand the various aspects of client behaviour.

Type of Change

  • Refactor (refactoring code, removing code, changing code structure)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

…a more structured and thematic grouping of related configuration settings
@ShocOne ShocOne merged commit 19c08ae into main Apr 25, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant