Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise timeout for runLocally to 300 seconds #955

Merged
merged 1 commit into from
Jan 16, 2017

Conversation

mbrodala
Copy link
Contributor

Similar to other locations this is now also raised to 5 minutes.

Q A
Bug fix? Yes
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

Similar to other locations this is now also raised to 5 minutes.
@antonmedv
Copy link
Member

Does it really needed?

@antonmedv
Copy link
Member

What about creating global config for setting local timeout?

@mbrodala
Copy link
Contributor Author

@Elfet It is necessary for all commands within recipes which do not provide a configuration option for the timeout argument of runLocally(). We've discovered that e.g. rsync does this, however not all locations do, e.g. local:vendors.

That's the background and the fact that the timeout was already raised to 300 seconds for the Local server (592e132).

@antonmedv
Copy link
Member

Ok, what about config option for that?

@antonmedv antonmedv merged commit 9680b11 into deployphp:master Jan 16, 2017
@mbrodala
Copy link
Contributor Author

@Elfet Yes, I'll probably add PRs for recipes to add config options. Thanks for merging. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants