move ShareBuild to the core api instead of build #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the build API is specifically meant for build orchestration
lukevmorris
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Since these endpoints operate at the scope of a build, I think we probably want to create a new file proto/depot/core/v1/build.proto and place the Share logic in there. As a followup later this cycle, we can maybe make some other currently private depot.core.v1.BuildService endpoints public via this file as well.
|
sounds great, will do :) |
lukevmorris
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the build API is specifically meant for build orchestration