-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency pass #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding a UI to this example? I think the UI from the create-near-app blank project will actually work here. It will make the app a lot better. We need to have more full stack content for rust to make it actually viable. This can be done in a follow up PR.
.cargo/config
Outdated
@@ -0,0 +1,3 @@ | |||
[build] | |||
target = "wasm32-unknown-unknown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you check if these are in a readme file somewhere? I remember we had documentation which mentioned these at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I have a PR I need to get back to making create-near-app
compatible with Windows. In there I had a command inside the build script, essentially:
# Note: see flags in ./cargo/config
I think I'll add it there and to the readme, good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding a UI to this example? I think the UI from the create-near-app blank project will actually work here. It will make the app a lot better. We need to have more full stack content for rust to make it actually viable. This can be done in a follow up PR.
I agree a UI is a good idea. I am really trying to focus on getting the examples standardized right now, but I think we should open an issue for this. It's actually taking longer than I thought as each example is a teeny bit different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
darn it, @janedegtiareva looks like the .cargo/config
is making tests fail somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulled out the .cargo/config
because it will force those flags onto the tests, which we don't want to do, apparently
rust-lang/cargo#6784
EDIT: the flags work well for this, but not the target
so we're going to keep it for that
The commit messages explain it. Basically want to have Gitpod run all the things so the user doesn't have to think about it, then shows them the
README-Gitpod.md
file.I will be testing this out on Windows, hence the modification to the
build.sh
file.