Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALWAL-167] Mission Response 및 API PathVariable 수정 #91

Merged
merged 3 commits into from
Aug 6, 2024
Merged

[WALWAL-167] Mission Response 및 API PathVariable 수정 #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e952c35
fix: Mission Response 및 API PathVariable 수정
dbscks97 Aug 3, 2024
939c335
fix: MissionController Test 수정
dbscks97 Aug 3, 2024
5573627
Merge branch 'develop' into fix/#89-missionrecord-response
dbscks97 Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/main/java/com/depromeet/stonebed/domain/mission/domain/Mission.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ public class Mission extends BaseTimeEntity {
@Column(name = "illustration_url")
private String illustrationUrl;

@Column(name = "hex_color")
private String hexColor;

@Builder
public Mission(String title) {
this.title = title;
Expand Down
10 changes: 3 additions & 7 deletions ...main/java/com/depromeet/stonebed/domain/mission/dto/response/MissionGetTodayResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,11 @@ public record MissionGetTodayResponse(
@Schema(description = "미션 제목", example = "산책하기")
@NotBlank(message = "Title cannot be blank")
String title,
@Schema(description = "일러스트 이미지 URL", example = "https://example.com/image.jpeg")
String illustrationUrl,
@Schema(description = "Hex 색상 값", example = "#FFFFFF") String hexColor) {
@Schema(description = "일러스트 이미지 URL", example = "https://image.walwal.life/image.jpeg")
String illustrationUrl) {

public static MissionGetTodayResponse from(Mission mission) {
return new MissionGetTodayResponse(
mission.getId(),
mission.getTitle(),
mission.getIllustrationUrl(),
mission.getHexColor());
mission.getId(), mission.getTitle(), mission.getIllustrationUrl());
}
}
2 changes: 1 addition & 1 deletion src/main/java/com/depromeet/stonebed/domain/missionRecord/api/MissionRecordController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public ResponseEntity<Void> startMission(@PathVariable("missionId") Long mission
}

@Operation(summary = "미션 기록 저장", description = "미션 완료 후 기록을 저장한다.")
@PostMapping
@PostMapping("/{missionId}")
public ResponseEntity<Void> saveMission(@PathVariable("missionId") Long missionId) {
missionRecordService.saveMission(missionId);
return ResponseEntity.ok().build();
Expand Down
3 changes: 1 addition & 2 deletions src/test/java/com/depromeet/stonebed/domain/mission/api/MissionControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ public void setUp() {
public void 오늘의_미션_조회_성공() throws Exception {
// Given
MissionGetTodayResponse missionGetTodayResponse =
new MissionGetTodayResponse(
1L, "Test Mission", "https://example.com/image.png", "#FFFFFF");
new MissionGetTodayResponse(1L, "Test Mission", "https://example.com/image.png");
when(missionService.getOrCreateTodayMission()).thenReturn(missionGetTodayResponse);

// When & Then
Expand Down
Loading